Skip to content

chore: pin tak to the v0.5.0 release - #289

Merged
dmccoystephenson merged 2 commits into
mainfrom
deps/tak-v0.5.0
Nov 20, 2026
Merged

dmccoystephenson merged 2 commits into
mainfrom
deps/tak-v0.5.0

Conversation

@dmccoystephenson

Copy link
Copy Markdown
Member

Moves the tak pin from the bare commit 86a6164 to the v0.5.0 release tag.

  • tak v0.5.0 was published by the release automation on 2026-11-20 after its tests, save-compat and consumers gates passed. The consumers gate ran this game's suite against the release candidate.
  • 86a6164 is an ancestor of v0.5.0, so the release adds the 12 tak commits made after the old pin and removes nothing.
  • Merging redeploys the game to the arcade.

drafted by Claude on behalf of Daniel Stephenson

🤖 Generated with Claude Code

dmccoystephenson and others added 2 commits November 20, 2026 01:32
tak v0.5.0 was published on 2026-11-20 and contains 86a6164, the
commit this game pinned; the pin now names the release tag instead
of a bare commit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LYNeuo1ijSVqDkSUuVN9Tg
The pin regex only matched a hex commit, so moving both pins to the
v0.5.0 tag made the check find no pin at all and fail.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dmccoystephenson

Copy link
Copy Markdown
Member Author

Review of this PR, with one fix pushed (3af9e88).

The first CI run failed 2 tests in tests/test_dockerfile.py (1146 passed, 2 failed). The pin regex there, tak @ git\+\S+?@[0-9a-f]+, only matched a hex commit. After both pins moved to @v0.5.0, it found no pin in either file. The regex now accepts a commit hash or a release tag. Two tests were added: one finds a tag pin, and one confirms that pins differing only in their tag do not count as matching. Both new tests fail with the old regex (it returns [] for both strings) and pass with the new one.

Self-review rubric:

  • Scope: PASS. The diff touches Dockerfile, requirements.txt (the pin bump) and tests/test_dockerfile.py (the check the bump broke). Nothing else is included. A reformat that black applied to an unrelated assert was reverted.
  • Tests-new: PASS. No production code was added. The changed regex is covered by test_tak_requirement_finds_a_release_tag_pin and test_tak_requirements_differing_only_in_tag_do_not_match.
  • Tests-fix: PASS. CI run 44703426603 shows both agreement tests failing on the old regex, and run 44717733515 passes on the new one.
  • Sibling structure: PASS. The new tests follow the # prepare / # call / # check layout of the tests next to them.
  • Docs: PASS. The test module docstring now says "a commit or a release tag". No README, PLANNING or schema text names the tak pin.
  • Issue resolution: N/A. No issue is attached; the PR was opened by the owner.
  • CI: PASS. test reports 1150 passed and the log shows tak-0.5.0 installed. docker passes. Local run: 1150 passed.
  • Schema-sync, Money-format, Deterministic-tests, Headless-pygame, camelCase: N/A. No persisted fields, money displays, randomness, pygame code or new identifiers were touched.

Do-not-auto-merge paths: none matched (no schemas/, saveFileManager.py, *JsonReaderWriter.py or workflow changes).

Out-of-diff note: a tag is a movable ref, while the old commit pin was not. If v0.5.0 were ever re-tagged, the deployed image and CI could silently pick up different code. Release tags in tak are created by automation and are not expected to move, so this is not treated as blocking.

This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).


drafted by Claude on behalf of Daniel Stephenson

@dmccoystephenson
dmccoystephenson merged commit ef23745 into main Nov 20, 2026
2 checks passed
@dmccoystephenson
dmccoystephenson deleted the deps/tak-v0.5.0 branch November 20, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant